Add missing aria labels #2715
Merged
Add missing aria labels #2715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinicius73
requested review from
juliusknorr,
luka-nextcloud,
max-nextcloud and
mejo-
mejo-
approved these changes
Jul 13, 2022
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
I didn't test this, but looks reasonable.
juliusknorr
reviewed
Jul 13, 2022
juliusknorr
reviewed
Jul 13, 2022
juliusknorr
reviewed
Jul 13, 2022
| :data-text-action-entry="actionEntry.key" | ||
| :title="actionEntry.label" | ||
| :aria-label="actionEntry.label" | ||
| role="menu" |
Member
There was a problem hiding this comment.
Shall we upstream this to https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/Actions/Actions.vue#L136 ?
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
juliusknorr
reviewed
Jul 13, 2022
Member
Author
|
/rebase |
nextcloud-command
force-pushed
the
fix/add-missing-aria-labels
branch
from
5d519c9 to
0ab43fa
Compare
vinicius73
force-pushed
the
fix/add-missing-aria-labels
branch
2 times, most recently
from
07ddad4 to
22213fd
Compare
Member
Author
|
/rebase |
nextcloud-command
force-pushed
the
fix/add-missing-aria-labels
branch
from
22213fd to
1cb2281
Compare
juliusknorr
force-pushed
the
fix/add-missing-aria-labels
branch
from
1cb2281 to
0f1fe29
Compare
juliusknorr
approved these changes
Jul 19, 2022
Member
Author
|
/rebase |
Signed-off-by: Vinicius Reis <[email protected]>
nextcloud-command
force-pushed
the
fix/add-missing-aria-labels
branch
from
0f1fe29 to
87d6bf4
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add some missing
aria-*androlesto improve accessibility