Bump @nextcloud/vue to 6.0.0-beta.3 #2794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
dependencies/nextcloud-vue6
branch
from
db0042d to
672e2e7
Compare
juliusknorr
force-pushed
the
dependencies/nextcloud-vue6
branch
from
2fede0f to
1104374
Compare
Member
|
viewer has been updated to vue 2.7 There no more errors like vuejs/vue#12627 |
Member
|
I just found a style error, it seems to work correctly. The main problem is the new popover component (floating-vue). I will send a PR to nextcloud-vue to address some of that behaviors. |
juliusknorr
force-pushed
the
dependencies/nextcloud-vue6
branch
2 times, most recently
from
a253e31 to
c32eae4
Compare
Member
Author
|
@vinicius73 I pushed an adjustment to the cypress selectors and it seems to be happy about that. Also ran another smoke test an couldn't find any obvious issues. Maybe you can later list your findings, so we have that tracked. Voting for getting this in fast, we can still follow up on smaller issues. |
Raudius
approved these changes
Aug 12, 2022
Contributor
Raudius
left a comment
Raudius
left a comment
There was a problem hiding this comment.
Tested against server master branch, working well! :)
Member
Author
|
This was referenced Aug 12, 2022
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Bumps [@nextcloud/eslint-config](https://github.com/nextcloud/eslint-config) from 8.0.0 to 8.1.2. - [Release notes](https://github.com/nextcloud/eslint-config/releases) - [Changelog](https://github.com/nextcloud/eslint-config/blob/master/CHANGELOG.md) - [Commits](nextcloud-libraries/eslint-config@v8.0.0...v8.1.2) --- updated-dependencies: - dependency-name: "@nextcloud/eslint-config" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
dependencies/nextcloud-vue6
branch
2 times, most recently
from
2a7654d to
ff3f55e
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
dependencies/nextcloud-vue6
branch
from
ff3f55e to
158a611
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
juliusknorr
changed the title
This was referenced Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still throwing some errors in the viewer as nextcloud/viewer#1319 / nextcloud/viewer#1300 are missing and the Vue instance has a different version there.
Ref vuejs/vue#12627
At some point we should probably rethink our way of embedding text in viewer to avoid version dependencies like that.