Skip to content

Update @nextcloud/vue to 6.0.0 #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 9 commits into from
Aug 23, 2022
Merged

Update @nextcloud/vue to 6.0.0 #1319

skjnldsv merged 9 commits into from
Aug 23, 2022

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 11, 2022 •
edited
Loading

@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Merged
Base automatically changed from dependabot/npm_and_yarn/vue-2.7.8 to master August 11, 2022 11:02
@juliusknorr juliusknorr force-pushed the dependencies/nextcloud-vue6 branch from feef129 to 91e5084 Compare August 11, 2022 12:10
@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 11, 2022

/compile amend /

@nextcloud-command nextcloud-command force-pushed the dependencies/nextcloud-vue6 branch from 91e5084 to d7ab8b5 Compare August 11, 2022 13:02
@juliusknorr juliusknorr force-pushed the dependencies/nextcloud-vue6 branch 3 times, most recently from 97eb4ef to 728881a Compare August 12, 2022 10:39
@skjnldsv skjnldsv force-pushed the dependencies/nextcloud-vue6 branch from a2fb110 to 7e61528 Compare August 18, 2022 11:29
skjnldsv
skjnldsv reviewed Aug 18, 2022
View reviewed changes
src/views/Viewer.vue
}
}
&.theme--dark::v-deep .button-vue--vue-tertiary {
Copy link
Member

@skjnldsv skjnldsv Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to enforce the theme used more beautifully with css variables now
As well with the data-theme attribute @juliushaertl

@skjnldsv skjnldsv force-pushed the dependencies/nextcloud-vue6 branch from dfeedb6 to 0fb6d8c Compare August 18, 2022 17:36
@skjnldsv skjnldsv added the 2. developing Work in progress label Aug 18, 2022
@skjnldsv skjnldsv self-assigned this Aug 18, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Aug 18, 2022
@skjnldsv skjnldsv changed the title Update @nextcloud/vue to 6.0.0-beta.1 Update @nextcloud/vue to 6.0.0 Aug 18, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Aug 18, 2022 •
edited
Loading

@juliushaertl do you know how we can adjust that here? Also the editor popups/modals
image
Getting the dom elements might be tricky as they come and go on the editor menu open/close 😕

@juliusknorr juliusknorr force-pushed the dependencies/nextcloud-vue6 branch from 0fb6d8c to 32698b1 Compare August 19, 2022 08:50
@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 19, 2022

Popovers like the ones from actions should be handled separately anyways by their own focus trap. Maybe you can share what the SfxModal-Wrapper does and how it gets initialised?

@skjnldsv
Copy link
Member

skjnldsv commented Aug 19, 2022

Popovers like the ones from actions should be handled separately anyways by their own focus trap. Maybe you can share what the SfxModal-Wrapper does and how it gets initialised?

External liv, this is either the SaveAs modal
image

Or the menus like this
image

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2022
Merged
@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 22, 2022

Is there any way you could trigger a callback on showing/hiding those? I assume they are handled fully by the image editor library :/

@skjnldsv
Copy link
Member

skjnldsv commented Aug 22, 2022

I assume they are handled fully by the image editor library :/

Yep!
I'll double check. But we might have to fix the focus trap

@vinicius73 vinicius73 mentioned this pull request Aug 23, 2022
Closed
2 tasks
@skjnldsv skjnldsv force-pushed the dependencies/nextcloud-vue6 branch from 32698b1 to 7a121e5 Compare August 23, 2022 13:58
@skjnldsv
Copy link
Member

skjnldsv commented Aug 23, 2022

Is there any way you could trigger a callback on showing/hiding those? I assume they are handled fully by the image editor library :/

Fixed, not super fond, but works™

@skjnldsv skjnldsv force-pushed the dependencies/nextcloud-vue6 branch from 7a121e5 to 61ee392 Compare August 23, 2022 15:37
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 23, 2022
@skjnldsv skjnldsv added the dependencies Pull requests that update a dependency file label Aug 23, 2022
@skjnldsv skjnldsv enabled auto-merge August 23, 2022 15:39
@skjnldsv
Bump @nextcloud/vue to beta 4
9320acb 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the dependencies/nextcloud-vue6 branch from 61ee392 to 9320acb Compare August 23, 2022 15:49
@skjnldsv skjnldsv merged commit 1aa8f17 into master Aug 23, 2022
@skjnldsv skjnldsv deleted the dependencies/nextcloud-vue6 branch August 23, 2022 16:16
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@kesselb kesselb mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @skjnldsv