fix: transations in status message #3764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/compile |
max-nextcloud
requested review from
a team,
luka-nextcloud and
marcelklehr
and removed request for
a team
juliusknorr
approved these changes
Feb 6, 2023
* Make sure the translation command for "Offline" can be parsed. Otherwise it will not be extracted as a translation entry. * Use `lastSave` as the variable name in the tooltip. That is what all the translations use right now. Fixes #3750. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/translations-in-status
branch
from
20de00d to
d055707
Compare
Collaborator
Author
|
/compile |
Passing run #8486 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Signed-off-by: nextcloud-command <[email protected]>
marcelklehr
approved these changes
Feb 6, 2023
Collaborator
Author
|
/backport to stable25 |
This was referenced Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastSaveas the variable name in the tooltip. That is what all the translations use right now.Fixes #3750.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)and the changes are covered with tests. We currently do not test translations. Might be worthwhile though as this was a regression.