Skip to content

fix: transations in status message #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 2 commits into from
Feb 6, 2023
Merged

fix: transations in status message #3764

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d055707
fix: transations in status message
max-nextcloud Feb 6, 2023
b537208
Compile assets
nextcloud-command Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: transations in status message 
* Make sure the translation command for "Offline" can be parsed.
  Otherwise it will not be extracted as a translation entry.
* Use `lastSave` as the variable name in the tooltip.
  That is what all the translations use right now.

Fixes #3750.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud
max-nextcloud committed Feb 6, 2023
commit d055707a6c60477d4e65518d91c4a35b6c5747e0
10 changes: 4 additions & 6 deletions src/components/Editor/Status.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,17 @@ export default {
computed: {
lastSavedStatus() {
if (this.hasConnectionIssue) {
return t('text',
this.$isMobile
? 'Offline'
: 'Offline, changes will be saved when online'
)
return this.$isMobile
? t('text', 'Offline')
: t('text', 'Offline, changes will be saved when online')
}
return this.dirtyStateIndicator ? t('text', 'Saving …') : t('text', 'Saved')
},
dirtyStateIndicator() {
return this.dirty || this.hasUnsavedChanges
},
lastSavedStatusTooltip() {
let message = t('text', 'Last saved {lastSaved}', { lastSaved: this.lastSavedString })
let message = t('text', 'Last saved {lastSave}', { lastSave: this.lastSavedString })
if (this.hasSyncCollission) {
message = t('text', 'The document has been changed outside of the editor. The changes cannot be applied.')
}
Expand Down