Vite/rollup: treat modules from deep imports as external #3821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we only treated direct imports of modules as external in rollup (e.g. `import ... from '@tiptap/core'`). Modules where we imported files directly (e.g. `import ... from '@tiptap/core/dist/index.js'` were not treated as external and thus bundled into our `dist/index.js`. With `@tiptap/pm` being introduced as meta-dependency for prosemirror modules, this led to duplicate instances of prosemirror modules. Fixes: #3820 Signed-off-by: Jonas <[email protected]>
Copy three small helper functions into our source code instead of dependencing on this old and abandonned module. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Member
Author
|
Mh, the Cypress failure looks unrelated 🤔 |
Passing run #8677 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
max-nextcloud
approved these changes
Feb 22, 2023
Collaborator
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
So far we only treated direct imports of modules as external in rollup (e.g.
import ... from '@tiptap/core'). Modules where we imported files directly (e.g.import ... from '@tiptap/core/dist/index.js') were not treated as external and thus bundled into ourdist/index.js.With
@tiptap/pmbeing introduced as meta-dependency for prosemirror modules, this led to duplicate instances of prosemirror modules.Fixes: #3820
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)