-
Notifications
You must be signed in to change notification settings - Fork 109
Use NcRichText component from @nextcloud/vue
#3859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed6fba9 to
303b89f
Compare
|
/compile |
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we import files from @nextcloud/vue/dist/.* now, we need to add a rule to vite.config.js:
diff --git a/vite.config.js b/vite.config.js
index 0b7885ce8..a1ee24e76 100644
--- a/vite.config.js
+++ b/vite.config.js
@@ -21,6 +21,7 @@ export default defineConfig({
/markdown-it\/.*/,
/@tiptap\/pm\/.*/,
/vue-material-design-icons\/.*/,
+ /@nextcloud\/vue\/.*/,
],
output: {
globals: { vue: 'Vue' },If you want me to, I can push a commit to this PR.
1 flaky tests on run #8826 ↗︎Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
@mejo- I don't exactly know the implications of doing that but fully trust your judgement 😁. |
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
2c4f40b to
31ccd5a
Compare
The reason for that is that we only treat imports that exactly match names of our dependencies from |
|
I rebased on current main and pushed my commit. |
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
🎉 Circular dependency is definitely going down with the next
@nextcloud/vuerelease which will includesNcRichTextand everything needed for the link picker and the reference widgets.refs nextcloud-libraries/nextcloud-vue#3841 nextcloud-libraries/nextcloud-vue#3812
I'll update
@nextcloud/vueand set this to "ready for review" once the new release is out.