fix: only initialize editor once #3893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
fix/recovery-sync-test
branch
from
593645c to
5dbd7bd
Compare
Collaborator
Author
|
/backport 5dbd7bd to stable26 |
2 flaky tests on run #8903 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > saves the actual file and document state |
Output
Screenshots
|
|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
max-nextcloud
force-pushed
the
fix/recovery-sync-test
branch
from
5dbd7bd to
eeee735
Compare
Collaborator
Author
|
/compile |
Member
|
Is the failing Cypress test the one you would expect to have fixed with this PR?
|
Collaborator
Author
Yes. I saw it fail occasionally locally - but three failures in a row is way too much. Will need to investigate some more. |
juliusknorr
approved these changes
Mar 6, 2023
When we recover a session the editor already exists. Start the syncing again as the polling backend is created from scratch. Do not attach further events to the editor and do not reset the content. Signed-off-by: Max <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
max-nextcloud
force-pushed
the
fix/recovery-sync-test
branch
from
7cda8e1 to
2d2c300
Compare
Collaborator
Author
|
I made the tests more robust i think. Let's see if they turn flaky eventually. The actual fix to the underlying problem would be #3899 . |
|
The backport to stable26 failed. Please do this backport manually. |
Member
|
back ported manually with #3900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
When we recover a session the editor already exists.
Make sure editing can be resumed:
Start the syncing again as the polling backend is created from scratch.
Do not attach further events to the editor
Do not reset the content.
Resolves: Test failures in sync spec
npm run lint/npm run stylelint/composer run cs:check)