[stable26] fix: only initialize editor once #3900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
changed the title
max-nextcloud
added
bug
1 flaky tests on run #8920 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mejo-
approved these changes
Mar 6, 2023
juliusknorr
approved these changes
Mar 6, 2023
4 tasks
When we recover a session the editor already exists. Start the syncing again as the polling backend is created from scratch. Do not attach further events to the editor and do not reset the content. Signed-off-by: Max <[email protected]>
juliusknorr
force-pushed
the
backport/stable26/3893-only-initialize-editor-once
branch
from
c99e50e to
f8bd87f
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
juliusknorr
deleted the
backport/stable26/3893-only-initialize-editor-once
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
When we recover a session the editor already exists. Start the syncing again as the polling backend is created from scratch. Do not attach further events to the editor and do not reset the content.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)