Get mimeIconUrl for media attachments without a session #3909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
requested review from
julien-nc,
juliusknorr,
luka-nextcloud and
max-nextcloud
mejo-
commented
Mar 7, 2023
mejo-
force-pushed
the
fix/media_preview_no_session
branch
from
60f12a5 to
0f6805c
Compare
mejo-
commented
Mar 7, 2023
1 flaky tests on run #9078 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mejo-
force-pushed
the
fix/media_preview_no_session
branch
2 times, most recently
from
d124e5b to
bee70d2
Compare
max-nextcloud
approved these changes
Mar 16, 2023
luka-nextcloud
approved these changes
Mar 16, 2023
* Prop `dark` for NcModal has to be a boolean * Custom validator for prop `images` should succeed if all images have basename and source set, not the other way round. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
In order to have non-image attachments rendered in editors without a session, `AttachmentResolver.resolve()` should return a candidate with the mimeType icon as url as last resort - because all endpoints from Text `AttachmentController` require a session. This fixes rendering of non-image attachments in RichTextReader. Fixes: #2919 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/media_preview_no_session
branch
from
bee70d2 to
0b0d268
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Member
Author
|
/backport to stable26 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
In order to have non-image attachments rendered in editors without a session,
AttachmentResolver.resolve()should return a candidate with the mimeType icon as url as last resort - because all endpoints from TextAttachmentControllerrequire a session. This fixes rendering of non-image attachments in RichTextReader.Fixes: #2919
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)