[stable26] Get mimeIconUrl for media attachments without a session #3955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
luka-nextcloud,
max-nextcloud and
mejo-
mejo-
approved these changes
Mar 16, 2023
3 flaky tests on run #9189 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| test link marks > link preview > shows a link preview |
Output
Screenshots
|
|
sync.spec.js • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Sync > saves the actual file and document state |
Output
Screenshots
|
|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Member
|
/compile amend |
nextcloud-command
force-pushed
the
backport/3909/stable26
branch
from
333cbf4 to
11dac26
Compare
mejo-
force-pushed
the
backport/3909/stable26
branch
from
11dac26 to
f9d5d28
Compare
* Prop `dark` for NcModal has to be a boolean * Custom validator for prop `images` should succeed if all images have basename and source set, not the other way round. Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
In order to have non-image attachments rendered in editors without a session, `AttachmentResolver.resolve()` should return a candidate with the mimeType icon as url as last resort - because all endpoints from Text `AttachmentController` require a session. This fixes rendering of non-image attachments in RichTextReader. Fixes: #2919 Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
backport/3909/stable26
branch
from
f9d5d28 to
8840265
Compare
Member
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3909