Skip to content

[stable26] Get mimeIconUrl for media attachments without a session #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 4 commits into from
Mar 23, 2023
Merged

[stable26] Get mimeIconUrl for media attachments without a session #3955

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01a92fe
Fix errors in ShowImageModal
mejo- Mar 7, 2023
574c7be
Add `@nextcloud/files` as dependency
mejo- Mar 15, 2023
8840265
Get mimeIconUrl for media attachments without a session
mejo- Mar 7, 2023
b1e7486
Compile assets
nextcloud-command Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix errors in ShowImageModal 
* Prop `dark` for NcModal has to be a boolean
* Custom validator for prop `images` should succeed if all images have
  basename and source set, not the other way round.

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Mar 23, 2023
commit 01a92fef36a1580f967b61b8241222366effa963
4 changes: 2 additions & 2 deletions src/components/ImageView/ShowImageModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
:has-next="true"
:has-previous="true"
:close-button-contained="false"
dark="true"
:dark="true"
@next="showNextImage"
@previous="showPreviousImage"
@close="$emit('close')">
Expand All @@ -33,7 +33,7 @@ export default {
validator(imagesList) {
return (imagesList.length === 0)
? true
: imagesList.findIndex(({ basename, source }) => !(basename && source)) !== -1
: imagesList.every(image => image.basename && image.source)
},
},
startIndex: {
Expand Down