[stable26] fix(SyncService): handle failing connection gracefully #4990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #12359 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > saves on close |
Screenshots
|
|
Review all test suite changes for PR #4990 ↗︎
juliusknorr
changed the title
mejo-
approved these changes
Nov 14, 2023
Also fixes the share cypress test. Signed-off-by: Max <[email protected]>
mejo-
force-pushed
the
fix/stable26-docStateVersion
branch
from
a73ef12 to
6164fb6
Compare
Signed-off-by: nextcloud-command <[email protected]>
Member
Hu, are we in RC phase for stable26 already? |
Member
Author
|
Yep, somehow thought I'd have seen the rc pr already merged, nevermind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting this specific commit to avoid random failures of cypress in https://github.com/nextcloud/text/pull/4990/files#diff-103df33bb085aaec0d6134982c312e96ecf58cf09335b9cf15964e17a45b4071R114
Signed-off-by: Max [email protected]
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)