Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 19, 2024

📝 Summary

It seems otherwise browser would read out the full URL with screen readers. We already have the alt text as user defined description for each image so we should make use of that.

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Feb 19, 2024
@juliusknorr juliusknorr added this to the Nextcloud 29 milestone Feb 19, 2024
@AndyScherzinger
Copy link
Member

/backport to stable28

@max-nextcloud max-nextcloud merged commit 29f0b1e into main Feb 19, 2024
@max-nextcloud max-nextcloud deleted the fix/a11y-alt branch February 19, 2024 19:38
@backportbot
Copy link

backportbot bot commented Feb 19, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/5393/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8a3c21a0

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5393/stable28

Error: Failed to clone repository: Failed to clone and cache repo: Cloning into '.'...
error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 1410 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr
Copy link
Member Author

/backport to stable28

:alt="alt"
class="image__main"
@load="onLoaded">
<div class="metadata">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl maybe we should hide the span below (class="name") for a11y? meaning making it aria-hidden="true". Because it duplicates the alt tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants