Skip to content

fix: Add alt attribute to image nodes #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 1 commit into from
Feb 19, 2024
Merged

fix: Add alt attribute to image nodes #5393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/nodes/ImageView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
<div class="media__wrapper">
<img v-show="loaded"
:src="imageUrl"
:alt="alt"
class="image__main"
@load="onLoaded">
<div class="metadata">
Copy link
Contributor

@susnux susnux Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl maybe we should hide the span below (class="name") for a11y? meaning making it aria-hidden="true". Because it duplicates the alt tag.

Expand Down