Fix some JS console errors #6597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property `isEmbedded` only gets provided in `ViewerComponent.vue`. When the editor gets created though other means, e.g. via editor API (`editor.js`), `isEmbedded` is not provided and thus produces an error: > Injection "isEmbedded" not found Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
elzody
approved these changes
Nov 4, 2024
juliusknorr
approved these changes
Nov 5, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some JS console errors
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)