Skip to content

Fix some JS console errors #6597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 2 commits into from
Nov 5, 2024
Merged

Fix some JS console errors #6597

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
976a292
fix(Editor.vue): provide default for injected `isEmbedded`
mejo- Nov 4, 2024
8bdf7ae
fix(assistant): Provide missing properties to Nextcloud Vue components
mejo- Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(Editor.vue): provide default for injected isEmbedded 
The property `isEmbedded` only gets provided in `ViewerComponent.vue`.
When the editor gets created though other means, e.g. via editor API
(`editor.js`), `isEmbedded` is not provided and thus produces an error:

> Injection "isEmbedded" not found

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Nov 4, 2024
commit 976a292aada99a97ebb1ce842b36a7eb56be46cc
4 changes: 3 additions & 1 deletion src/components/Editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ export default {

return val
},
inject: ['isEmbedded'],
inject: {
isEmbedded: { default: false },
},
props: {
richWorkspace: {
type: Boolean,
Expand Down