-
Notifications
You must be signed in to change notification settings - Fork 109
fix(files): set focus on image description right after inserting #6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: julia.kirschenheuter <[email protected]>
|
Thanks for tackling this. I'd suggest to backport the fix to stable30 and stable29 at least. |
|
/backport to stable29 |
|
/backport to stable30 |
|
/compile amend / |
|
@JuliaKirschenheuter there's no need to compile PRs before merging them in the text repo (even though it's a shipped app). We have a CI job that does this after the merge in this repo - which greatly simplifies working with PRs. |
|
If #6843 is caused by this, the inconvenience created is larger than what was fixed by this mr. The focusing is inconsistent anyway, for example crating a note (warn, info etc..) does not focus it. |
📝 Summary
Set focus on image description right after inserting
After inserting an attachment, focus should go after the the image -> to the image description
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)