Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

📝 Summary

Set focus on image description right after inserting

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2024-11-06 17-59-44 Screenshot from 2024-11-06 17-59-54

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@mejo-
Copy link
Member

mejo- commented Nov 6, 2024

Thanks for tackling this. I'd suggest to backport the fix to stable30 and stable29 at least.

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable29

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable30

@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@mejo- mejo- merged commit 1fb968b into main Nov 7, 2024
61 checks passed
@mejo- mejo- deleted the fix/6152-set-focus-on-description branch November 7, 2024 10:07
@mejo-
Copy link
Member

mejo- commented Nov 7, 2024

@JuliaKirschenheuter there's no need to compile PRs before merging them in the text repo (even though it's a shipped app). We have a CI job that does this after the merge in this repo - which greatly simplifies working with PRs.

@MrRinkana
Copy link

If #6843 is caused by this, the inconvenience created is larger than what was fixed by this mr. The focusing is inconsistent anyway, for example crating a note (warn, info etc..) does not focus it.

@mejo-
Copy link
Member

mejo- commented May 7, 2025

If #6843 is caused by this, the inconvenience created is larger than what was fixed by this mr. The focusing is inconsistent anyway, for example crating a note (warn, info etc..) does not focus it.

You're right. I just opened PR #7201 in order to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants