-
Notifications
You must be signed in to change notification settings - Fork 109
fix(image): Only focus image description on newly inserted image #7201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7201 +/- ##
==========================================
- Coverage 52.35% 52.34% -0.01%
==========================================
Files 479 479
Lines 41669 41681 +12
Branches 1023 1023
==========================================
+ Hits 21815 21818 +3
- Misses 19752 19761 +9
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@max-nextcloud I'm curious what you think about the approach with The challenge is to detect whether the loaded attachment just got inserted or whether it's an existing attachment in the node view I had to find a way to register the newly inserted image from |
Fixes: #6843 Fixes: nextcloud/collectives#1740 Signed-off-by: Jonas <[email protected]>
f941aab to
f4bf663
Compare
max-nextcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change does what it's intended to do.
However I think the underlying problem is a different one.
I think the alt text should be focused directly after inserting the image - even if the image has not been loaded yet. But it seems we only render the alt text once the image has been loaded. We should always render the alt text. If the image fails to load or takes a long time the alt text might tell what is supposed to be displayed.
Also - if i insert an image and the processing takes a long time so I continue typing somewhere else I would not expect the focus to be moved once the image finished loading.
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works, thank you!
|
/backport to stable31 |
|
I think this patch introduced this behaviour (video below). Clicking around causes only the isLastInserted ImageView to reload. Importantly, it only happens when you click in between paragraphs...?! I don't understand enough yet about how these parts interact to suggest a fix though 😅 Screencast.from.2025-05-09.09-19-59.webm |
Fixes: #6843
Fixes: nextcloud/collectives#1740
Fixes a regression from #6609
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)