Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 15, 2025

📝 Summary

🖼️ Screenshots

🏚️ Before

Screenshot from 2025-01-30 14-46-31

🏡 After

Screenshot from 2025-01-30 14-46-12
Peek 2025-01-30 14-43

@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 96.33028% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.10%. Comparing base (e5f9b07) to head (a3a58e0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/helpers/filePicker.js 46.15% 7 Missing ⚠️
src/components/Menu/ActionInsertLink.vue 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6856      +/-   ##
==========================================
+ Coverage   51.86%   59.10%   +7.23%     
==========================================
  Files         474      475       +1     
  Lines       40189    35620    -4569     
  Branches      988      987       -1     
==========================================
+ Hits        20845    21054     +209     
+ Misses      19240    14463    -4777     
+ Partials      104      103       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch from a1dc138 to ebc2d27 Compare January 16, 2025 15:47
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch 2 times, most recently from bc78ba4 to bcbb1d0 Compare January 30, 2025 13:44
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review January 30, 2025 13:44
@JuliaKirschenheuter
Copy link
Contributor Author

/rebase

@JuliaKirschenheuter
Copy link
Contributor Author

@marcoambrosini could you please have a look into current state? Thank you!

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch from bcbb1d0 to 1c4e1c3 Compare January 31, 2025 09:34
@juliusknorr
Copy link
Member

@JuliaKirschenheuter No need to commit the bundle js files in this repo, they get updated once merged.

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch from 1c4e1c3 to d8a7b03 Compare January 31, 2025 14:35
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch 2 times, most recently from ef05e27 to 7cf65de Compare February 18, 2025 18:32
@juliusknorr juliusknorr force-pushed the enh/6817-Suggestions-on-smart-picking branch from 7cf65de to 9bfba21 Compare March 18, 2025 09:34
@juliusknorr juliusknorr added enhancement New feature or request 3. to review and removed 2. developing labels Mar 18, 2025
@juliusknorr
Copy link
Member

@marcoambrosini Can you have a look UI wise? The spacing between the first line and the suggesions looks a bit off to me

@JuliaKirschenheuter Tested and functionality works as expected. Please check the remaining CI failures.

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch 2 times, most recently from 7124483 to 2d7043d Compare March 19, 2025 15:36
@JuliaKirschenheuter
Copy link
Contributor Author

Hi @marcoambrosini, could you please have a look?

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch from 2d7043d to d94f9ff Compare March 20, 2025 12:31
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points from my side:
1- The buttons group should be left aligned
2- This buttons flicker when opening a file that already have text
3- I think that the smart smart picker button should open the smart picker inline and not in the dialog
4- I think this buttons should be secondary
5- Possibly they should be directly below the first line, not hanging in the middle of the page

Ref
Screenshot 2025-03-20 at 14 34 38

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch 2 times, most recently from 81fb273 to a1e8e36 Compare March 20, 2025 16:52
Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6817-Suggestions-on-smart-picking branch from a1e8e36 to a3a58e0 Compare March 21, 2025 10:30
@juliusknorr
Copy link
Member

@JuliaKirschenheuter Best also leave a comment on what you have done, otherwise others cannot follow that

As noted via chat 1,4,5 are addressed.

One cypress runner had a temporary issue before starting cypress, restarted.

2- This buttons flicker when opening a file that already have text
3- I think that the smart smart picker button should open the smart picker inline and not in the dialog

Would be fine as a follow up for me, but @JuliaKirschenheuter feel free to also push that here still.

@juliusknorr
Copy link
Member

3- I think that the smart smart picker button should open the smart picker inline and not in the dialog

Thinking about this one a bit more again, it might be arguable if we want that button at all, as we have the plus button on the left doing the same.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JuliaKirschenheuter
Copy link
Contributor Author

Would be fine as a follow up for me,

@marcoambrosini could i merge this PR and take points 2 and 3 (?) (it might be arguable if we want that button at all, as we have the plus button on the left doing the same) as follow-up?

@JuliaKirschenheuter JuliaKirschenheuter merged commit 9b5eac6 into main Mar 21, 2025
75 of 77 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/6817-Suggestions-on-smart-picking branch March 21, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestions on smart picking

4 participants