Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

๐Ÿ“ Summary

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before ๐Ÿก After
Screenshot from 2025-03-26 10-40-39 Screenshot from 2025-03-26 10-39-08

๐Ÿ Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 58.81%. Comparing base (019ff9d) to head (af6e474).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7029      +/-   ##
==========================================
+ Coverage   51.92%   58.81%   +6.89%     
==========================================
  Files         478      477       -1     
  Lines       40610    35799    -4811     
  Branches      990      989       -1     
==========================================
- Hits        21085    21055      -30     
+ Misses      19419    14639    -4780     
+ Partials      106      105       -1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaKirschenheuter I would not remove this because actually the + button should only be visible when the mouse is hovering the line

@JuliaKirschenheuter
Copy link
Contributor Author

@JuliaKirschenheuter I would not remove this because actually the + button should only be visible when the mouse is hovering the line

Hi @marcoambrosini, but what about #6856 (comment) and you confirmed it in chat too

@marcoambrosini
Copy link
Member

Sorry I didn't think about this before, but that plus icon being always shown is actually a bug

@JuliaKirschenheuter
Copy link
Contributor Author

Sorry I didn't think about this before, but that plus icon being always shown is actually a bug

Ok, should i revert this changes then and close this Issue?

@JuliaKirschenheuter
Copy link
Contributor Author

closing issue, #7029 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove a smart picker button from suggestions bar

3 participants