Skip to content

Conversation

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented May 5, 2025

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@luka-nextcloud luka-nextcloud added bug Something isn't working 3. to review labels May 5, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in πŸ“ Office team May 5, 2025
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to πŸ‘€ In review in πŸ“ Office team May 5, 2025
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 51.83%. Comparing base (865a88f) to head (7d35807).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/helpers/filePicker.js 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7180      +/-   ##
==========================================
- Coverage   51.85%   51.83%   -0.02%     
==========================================
  Files         479      479              
  Lines       41580    41595      +15     
  Branches     1002     1002              
==========================================
  Hits        21561    21561              
- Misses      19914    19929      +15     
  Partials      105      105              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well πŸ‘

@mejo- mejo- merged commit 5256464 into main May 6, 2025
64 of 66 checks passed
@mejo- mejo- deleted the fix-submit-button-on-file-picker-dialog branch May 6, 2025 12:50
@github-project-automation github-project-automation bot moved this from πŸ‘€ In review to β˜‘οΈ Done in πŸ“ Office team May 6, 2025
@mejo-
Copy link
Member

mejo- commented May 6, 2025

/backport to stable31

@backportbot
Copy link

backportbot bot commented May 6, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/7180/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7d358079

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7180/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@mejo-
Copy link
Member

mejo- commented May 6, 2025

/backport 7d35807 to stable31

@backportbot
Copy link

backportbot bot commented May 6, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/7180/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7d358079

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7180/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

mejo- added a commit that referenced this pull request May 6, 2025
Manual backport of #7180

Signed-off-by: Jonas <[email protected]>
@mejo-
Copy link
Member

mejo- commented May 6, 2025

Manual backport to stable31 at #7190

@luka-nextcloud
Copy link
Contributor Author

/backport to stable30

@luka-nextcloud
Copy link
Contributor Author

/backport to stable29

@backportbot
Copy link

backportbot bot commented May 6, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/7180/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7d358079

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7180/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented May 6, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/7180/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7d358079

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7180/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug] the submit button on file picker dialog showing "Choose <user id>"

3 participants