feat(psalm): Treat deprecated code as error #7241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from nextcloud/server#52860 Signed-off-by: Jonas <[email protected]>
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Office team
juliusknorr
reviewed
May 20, 2025
| </errorLevel> | ||
| </UndefinedDocblockClass> | ||
| <DeprecatedClass> | ||
| <errorLevel type="suppress"> |
Member
There was a problem hiding this comment.
Not sure i get this right, but wouldn't this suppress all of them directly? If we have any we should rather add to the baseline, right?
Member
Author
There was a problem hiding this comment.
Indeed, I should have checked more thoroughly. Thanks for catching this.
juliusknorr
reviewed
May 20, 2025
| @@ -1,25 +1,25 @@ | |||
| <?xml version="1.0"?> | |||
| <psalm | |||
| errorLevel="2" | |||
Member
There was a problem hiding this comment.
We are at error level 2 which should already throw errors if we have deprecations in use:
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 📝 Office team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from nextcloud/server#52860
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)