feat(psalm): Mark all usage of deprecated code as error #52860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
provokateurin
requested review from
ChristophWurst,
come-nc,
nickvergessen and
susnux
provokateurin
requested review from
nfebe and
skjnldsv
and removed request for
a team
ChristophWurst
approved these changes
May 15, 2025
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
PR authors will hate Psalm and not the reviewer who points these out. I'm in 👍
nit: semantic commit is ci or chore but not feat as there is no new feature added to the product 🤓
come-nc
approved these changes
May 15, 2025
3 tasks
mejo-
added a commit
to nextcloud/text
that referenced
this pull request
May 20, 2025
Copied from nextcloud/server#52860 Signed-off-by: Jonas <[email protected]>
mejo-
added a commit
to nextcloud/collectives
that referenced
this pull request
May 20, 2025
Copied from nextcloud/server#52860 Signed-off-by: Jonas <[email protected]>
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on #52853.
The idea is to prevent any new code to use already deprecated stuff. It will not be possible everywhere since we sometimes have no replacement, but then it should just be added to the baseline.
This change adds a lot to the baseline, but it's basically just a todo list for technical debt cleanups :)
Checklist