feat(status): Display offline state instead of session list #7420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7420 +/- ##
==========================================
+ Coverage 53.09% 60.38% +7.28%
==========================================
Files 501 501
Lines 43134 38410 -4724
Branches 1141 1130 -11
==========================================
+ Hits 22904 23193 +289
+ Misses 20121 15109 -5012
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
force-pushed
the
enh/offline_state
branch
5 times, most recently
from
7ae38d6 to
34792f9
Compare
mejo-
commented
Aug 14, 2025
max-nextcloud
force-pushed
the
enh/offline_state
branch
2 times, most recently
from
d7ebe25 to
dd0377c
Compare
Signed-off-by: Jonas <[email protected]>
Fixes: #7282 Signed-off-by: Jonas <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/offline_state
branch
3 times, most recently
from
80cf888 to
053afa4
Compare
Drop SessionConnection entirely. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
`cy.logout()` opens the logout page - which takes quite a while if no page is open. `cy.clearCookies()` has the same effect but without the slow page load. Reduces runtime from 1:23 to 1:07 for this test. Signed-off-by: Max <[email protected]>
`syncService.lock` does not exist anymore. Also cleanup unused `baseVersionEtag`. Signed-off-by: Max <[email protected]>
We store it to make sure we are reconnecting to the same editing session. So the whole point is that it does not change in between. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/offline_state
branch
from
053afa4 to
b3e511c
Compare
max-nextcloud
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Todo
Take connection from useConnection() into account in useNetworkState() composableDistinguish between your device is offline (
wifi_off) and no session connection - maybe cloud is offline (cloud_off).🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)