Skip to content

feat(status): Display offline state instead of session list #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 9 commits into from
Aug 19, 2025
Merged

feat(status): Display offline state instead of session list #7420

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60eb902
feat(useNetworkState): composable to get network online/offline state
mejo- Jul 8, 2025
c01ddd0
feat(status): Display offline state instead of session list
mejo- Jul 8, 2025
94bfd51
enh(offline): disable file uploads when offline
max-nextcloud Jul 8, 2025
b8cb159
chore(refactor): use GuestNameDialog directly in SessionList
max-nextcloud Aug 14, 2025
3070f53
chore(refactor): use connection to update guest name
max-nextcloud Aug 13, 2025
579abd7
enh(status): also show connection issues as cloud_off
max-nextcloud Aug 13, 2025
96f15f9
chore(test): speed up cy test
max-nextcloud Aug 16, 2025
251993d
fix(editor): use document.lock
max-nextcloud Aug 17, 2025
b3e511c
chore(cleanup): no need for reactive baseVersionEtag
max-nextcloud Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(cleanup): no need for reactive baseVersionEtag 
We store it to make sure we are reconnecting to the same editing session.
So the whole point is that it does not change in between.

Signed-off-by: Max <max@nextcloud.com>
  • Loading branch information
@max-nextcloud
max-nextcloud committed Aug 18, 2025
commit b3e511ca3a325405f12af0d43fc2b1d377444d9d
6 changes: 3 additions & 3 deletions src/composables/useConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function provideConnection(props: {
initialSession?: InitialData
shareToken?: string
}) {
const baseVersionEtag = shallowRef<string | undefined>(undefined)
let baseVersionEtag: string | undefined
const connection = shallowRef<Connection | undefined>(undefined)
const openData = shallowRef<OpenData | undefined>(undefined)
const openConnection = async () => {
Expand All @@ -60,9 +60,9 @@ export function provideConnection(props: {
guestName,
token: props.shareToken,
filePath: props.relativePath,
baseVersionEtag: baseVersionEtag.value,
baseVersionEtag,
}))
baseVersionEtag.value = data.document.baseVersionEtag
baseVersionEtag = data.document.baseVersionEtag
connection.value = opened
openData.value = data
return data
Expand Down
Loading