Skip to content

chore(update): explicitly import l10n where needed #7447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 2 commits into from
Jul 15, 2025
Merged

chore(update): explicitly import l10n where needed #7447

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdb871b
chore(update): explicitly import l10n where needed
max-nextcloud Jul 14, 2025
4557bc7
fix(richworkspace): load after mounted.
max-nextcloud Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(richworkspace): load after mounted. 
Get file info when hasRichworkspace turns true.

The render function in `FilesWorkspaceHeader`
runs with `hasRichWorkspace` false and mounts the Component.
Then the update function runs with `hasRichWorkspace` true.
Now the component needs to load the workspace.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud
max-nextcloud committed Jul 15, 2025
commit 4557bc77a4a142263e3b1b489f9dd9ee9146f699
3 changes: 3 additions & 0 deletions src/views/RichWorkspace.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@
},
hasRichWorkspace(value) {
this.localHasRichWorkspace = value
if (value) {
this.getFileInfo()

Check warning on line 116 in src/views/RichWorkspace.vue

View check run for this annotation

Codecov / codecov/patch

src/views/RichWorkspace.vue#L116 

Added line #L116 was not covered by tests
}
},
},
mounted() {
Expand Down Expand Up @@ -230,7 +233,7 @@
this.localHasRichWorkspace = false
}
},
t,

Check warning on line 236 in src/views/RichWorkspace.vue

View check run for this annotation

Codecov / codecov/patch

src/views/RichWorkspace.vue#L236 

Added line #L236 was not covered by tests
},
}
</script>
Expand Down
Loading