chore(update): explicitly import l10n where needed #7447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7447 +/- ##
==========================================
+ Coverage 52.70% 59.70% +7.00%
==========================================
Files 495 494 -1
Lines 42284 37431 -4853
Branches 1089 1087 -2
==========================================
+ Hits 22284 22347 +63
+ Misses 19893 14978 -4915
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
chore/import-l10n-t
branch
from
fb2ca02 to
7029658
Compare
Get file info when hasRichworkspace turns true. The render function in `FilesWorkspaceHeader` runs with `hasRichWorkspace` false and mounts the Component. Then the update function runs with `hasRichWorkspace` true. Now the component needs to load the workspace. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
chore/import-l10n-t
branch
from
7029658 to
4557bc7
Compare
mejo-
approved these changes
Jul 15, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Cool, thanks for the cleanup. Probably something we should do in Collectives as well.
Collaborator
Author
|
/backport 4557bc7 to stable31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(richworkspace): load after mounted.
Get file info when hasRichworkspace turns true.
The render function in
FilesWorkspaceHeaderruns with
hasRichWorkspacefalse and mounts the Component.Then the update function runs with
hasRichWorkspacetrue.Now the component needs to load the workspace.
chore(update): explicitly import l10n where needed
It's the recommended way to handle @nextcloud/l10n these days.