Skip to content

[stable31] fix(richworkspace): load after mounted. #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-nextcloud merged 1 commit into from
Jul 15, 2025
Merged

[stable31] fix(richworkspace): load after mounted. #7451

max-nextcloud merged 1 commit into from
Jul 15, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jul 15, 2025 •
edited
Loading

@max-nextcloud @backportbot
fix(richworkspace): load after mounted.
070b83f 
Get file info when hasRichworkspace turns true.

The render function in `FilesWorkspaceHeader`
runs with `hasRichWorkspace` false and mounts the Component.
Then the update function runs with `hasRichWorkspace` true.
Now the component needs to load the workspace.

Signed-off-by: Max <[email protected]>
@backportbot backportbot bot requested a review from mejo- July 15, 2025 11:14
@backportbot backportbot bot added this to the Nextcloud 31.0.8 milestone Jul 15, 2025
@max-nextcloud max-nextcloud enabled auto-merge July 15, 2025 11:14
@codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.50%. Comparing base (c3d4036) to head (070b83f).
Report is 2 commits behind head on stable31.

Files with missing lines Patch % Lines
src/views/RichWorkspace.vue 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           stable31    #7451      +/-   ##
============================================
- Coverage     51.50%   51.50%   -0.01%     
============================================
  Files           290      290              
  Lines         41165    41166       +1     
  Branches        840      840              
============================================
  Hits          21204    21204              
- Misses        19841    19842       +1     
  Partials        120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud merged commit 994e201 into stable31 Jul 15, 2025
63 of 64 checks passed
@max-nextcloud max-nextcloud deleted the backport/7447/stable31 branch July 15, 2025 11:49
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 5, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees

@max-nextcloud max-nextcloud

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 31.0.8

Development

Successfully merging this pull request may close these issues.

2 participants

@max-nextcloud