Skip to content

fix(readonly-bar): Clean up read-only menu bar to behave consistently with normal menu bar #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mejo- merged 3 commits into from
Sep 17, 2025
Merged

fix(readonly-bar): Clean up read-only menu bar to behave consistently with normal menu bar #7560

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152e1cb
fix(readonly-bar): Clean up read-only menu bar to behave consistently…
pbirrer Aug 22, 2025
f1d3c95
chore: code style fixes by prettier
mejo- Sep 17, 2025
5515deb
text(cy): Fix CSS selectors for readonly bar
mejo- Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: code style fixes by prettier 
Signed-off-by: Jonas <[email protected]>
  • Loading branch information
@mejo-
mejo- committed Sep 17, 2025
commit f1d3c95a24f1e684e6ec00443320e8a5560af1e4
2 changes: 1 addition & 1 deletion src/components/Editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
@outline-toggled="outlineToggled">
<MainContainer v-if="contentLoaded">
<!-- Readonly -->
<template v-if="readOnly || (openReadOnlyEnabled && !editMode)">
<template v-if="readOnly || (openReadOnlyEnabled && !editMode)">
<slot name="readonlyBar">
Copy link
Collaborator

@max-nextcloud max-nextcloud Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slot is used by the collectives app to alter the content of the read only bar. I think we need to keep it so that collectives can continue doing that.

Copy link
Contributor Author

@pbirrer pbirrer Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, sorry about that! I readded the slot. However, it's now a direct child of the MainContainer component, which is the same setup as here:

text/src/components/Editor/MarkdownContentEditor.vue

Lines 11 to 19 in f405547

<MainContainer>
<template v-if="showMenuBar">
<MenuBar v-if="!readOnly" :autohide="false" />
<slot v-else name="readonlyBar">
<ReadonlyBar />
</slot>
</template>
<ContentContainer />
</MainContainer>

Do you think that could be an issue? Personally, I feel it’s better to let the ReadonlyBar handle its own CSS styling.

<ReadonlyBar
:is-hidden="hideMenu"
Expand Down