Skip to content

Conversation

@pbirrer
Copy link
Contributor

@pbirrer pbirrer commented Aug 22, 2025

📝 Summary

This pull request addresses several issues related to read-only mode:

  • The README.md viewer in the file app no longer displays the read-only menu bar.
  • The read-only menu bar now spans the full viewport width.
  • Improved mobile support.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this. 💙

I just had a brief look at the code and so far it looks good. There's just one aspect that needs to be addressed.

I'll try this out later.

<ReadonlyBar
v-if="readOnly || (openReadOnlyEnabled && !editMode)"
class="text-editor--readonly-bar">
<slot name="readonlyBar">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slot is used by the collectives app to alter the content of the read only bar. I think we need to keep it so that collectives can continue doing that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, sorry about that! I readded the slot. However, it's now a direct child of the MainContainer component, which is the same setup as here:

<MainContainer>
<template v-if="showMenuBar">
<MenuBar v-if="!readOnly" :autohide="false" />
<slot v-else name="readonlyBar">
<ReadonlyBar />
</slot>
</template>
<ContentContainer />
</MainContainer>

Do you think that could be an issue? Personally, I feel it’s better to let the ReadonlyBar handle its own CSS styling.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tackling this @pbirrer 🙏

I tested it both in standalone Text and Collectives and it looks much cleaner now.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.77%. Comparing base (5dccd79) to head (5515deb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7560      +/-   ##
==========================================
+ Coverage   52.93%   59.77%   +6.83%     
==========================================
  Files         503      502       -1     
  Lines       43829    38966    -4863     
  Branches     1129     1128       -1     
==========================================
+ Hits        23203    23291      +88     
+ Misses      20517    15567    -4950     
+ Partials      109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo-
Copy link
Member

mejo- commented Sep 17, 2025

/backport to stable32

@mejo-
Copy link
Member

mejo- commented Sep 17, 2025

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants