-
Notifications
You must be signed in to change notification settings - Fork 109
fix: add close button when open readonly files on mobile app #7624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Reportโ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7624 +/- ##
=======================================
Coverage 59.54% 59.54%
=======================================
Files 310 310
Lines 38748 38754 +6
Branches 937 937
=======================================
+ Hits 23072 23078 +6
Misses 15568 15568
Partials 108 108 โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! I didn't test yet, just reviewed the code changes.
021522c to
8b770e2
Compare
8b770e2 to
00c720c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just now took a deeper look. I think there's no need to add the button to the Editor.vue component manually. Instead, you should make sure that the #header template from DirectEditing.vue is added to the <ReadOnlyBar> element in Editor.vue just like it's done for <MenuBar>.
While testing this, I realized that the ReadOnlyBar doesn't display well on mobile (at the bottom), it's cut off and the border line is on the wrong side. If you could take a look into improving this and harmonizing it with how MenuBar is displayed on mobile, that would be awesome. If not we can also do it in a follow-up PR. (already tackled in #7560)
|
#7560 seems related. |
Ah wow, I missed that. It seems to address my second comment from above ๐ Will take a look. |
So this is no longer necessary as it got tackled in #7560 already ๐ |
Signed-off-by: Luka Trovic <[email protected]>
00c720c to
9526394
Compare
|
/backport to stable32 |
|
/backport to stable30 |
|
/backport to stable31 |
๐ Summary
Add close button when open read-only files on mobile app
๐ผ๏ธ Screenshots
๐ Checklist
npm run lint/npm run stylelint/composer run cs:check)