fix: temporary fix useEditor composable #7627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luka Trovic <[email protected]>
luka-nextcloud
requested review from
max-nextcloud and
mejo-
as code owners
Contributor
Author
|
It's following the temporary fix that was mentioned here #7381 (comment) |
st3iny
reviewed
Sep 10, 2025
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
I tested this locally and it worked.
But I'm not sure what will happen if the text editor is mounted multiple times on a single page. The "global" variable is shared between all instances I think which will always return the same editor.
Collaborator
|
I wonder if we could go back to options api provide in the components that currently call provideEditor. It's what we used before and I think it should be possible to provide something in the options api that is returned from the setup function. update: I pushed what i mean in #7628 - could you give it a try @st3iny ? |
Collaborator
|
superseeded by #7643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Temporary fix the useEditor composable to make editor work in Deck card description
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)