-
Notifications
You must be signed in to change notification settings - Fork 109
fix(editor): rollback to the old vue2 provide hack #7628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4888c3e to
9305516
Compare
Calling `provide` in the setup function is still buggy in vue2. This led to the editor not being rendered in deck. Signed-off-by: Max <[email protected]>
9305516 to
e342497
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7628 +/- ##
==========================================
+ Coverage 52.96% 59.74% +6.78%
==========================================
Files 503 502 -1
Lines 43776 38853 -4923
Branches 1129 1128 -1
==========================================
+ Hits 23184 23211 +27
+ Misses 20483 15534 -4949
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This patch applied at least displays the content again for me 👍 |
|
@max-nextcloud I have made some tests. We can see the card description now, the smart picker works, but there are some js errors which break the editor menu bar. |
|
@luka-nextcloud can you share the errors? |
|
|
Superseeded by #7643 |

Calling
providein the setup function is still buggy in vue2.This led to the editor not being rendered in deck.