Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

Calling provide in the setup function is still buggy in vue2.

This led to the editor not being rendered in deck.

@max-nextcloud max-nextcloud force-pushed the fix/provide-editor-with-options-api branch from 4888c3e to 9305516 Compare September 10, 2025 22:11
Calling `provide` in the setup function is still buggy in vue2.

This led to the editor not being rendered in deck.

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud force-pushed the fix/provide-editor-with-options-api branch from 9305516 to e342497 Compare September 10, 2025 22:20
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.74%. Comparing base (c60ec13) to head (e342497).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/components/BaseReader.vue 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7628      +/-   ##
==========================================
+ Coverage   52.96%   59.74%   +6.78%     
==========================================
  Files         503      502       -1     
  Lines       43776    38853    -4923     
  Branches     1129     1128       -1     
==========================================
+ Hits        23184    23211      +27     
+ Misses      20483    15534    -4949     
+ Partials      109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blizzz
Copy link
Member

blizzz commented Sep 11, 2025

This patch applied at least displays the content again for me 👍

@luka-nextcloud
Copy link
Contributor

@max-nextcloud I have made some tests. We can see the card description now, the smart picker works, but there are some js errors which break the editor menu bar.
image

@max-nextcloud
Copy link
Collaborator Author

@luka-nextcloud can you share the errors?

@luka-nextcloud
Copy link
Contributor

@luka-nextcloud can you share the errors?

@max-nextcloud

[Vue warn]: Error in setup: "TypeError: Cannot destructure property 'isPublic' of 'inject(...)' as it is undefined."

found in

---> <Wrapper> at /home/luka/nextcloud/text-main/src/components/Editor/Wrapper.vue
       <MarkdownContentEditor> at /home/luka/nextcloud/text-main/src/components/Editor/MarkdownContentEditor.vue
         <Root>

TypeError: Cannot destructure property 'isPublic' of 'inject(...)' as it is undefined.
    at useEditorFlags (useEditorFlags.ts:31:10)
    at setup (Wrapper.vue:71:1)

[Vue warn]: Property or method "isRichWorkspace" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://v2.vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

found in

---> <Wrapper> at /home/luka/nextcloud/text-main/src/components/Editor/Wrapper.vue
       <MarkdownContentEditor> at /home/luka/nextcloud/text-main/src/components/Editor/MarkdownContentEditor.vue
         <Root>

[Vue warn]: Property or method "isRichWorkspace" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://v2.vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

found in

---> <MenuBar> at /home/luka/nextcloud/text-main/src/components/Menu/MenuBar.vue
       <MainContainer> at /home/luka/nextcloud/text-main/src/components/Editor/MainContainer.vue
         <Wrapper> at /home/luka/nextcloud/text-main/src/components/Editor/Wrapper.vue
           <MarkdownContentEditor> at /home/luka/nextcloud/text-main/src/components/Editor/MarkdownContentEditor.vue
             <Root>

[Vue warn]: Property or method "isRichEditor" is not defined on the instance but referenced during render. Make sure that this property is reactive, either in the data option, or for class-based components, by initializing the property. See: https://v2.vuejs.org/v2/guide/reactivity.html#Declaring-Reactive-Properties.

found in

---> <MenuBar> at /home/luka/nextcloud/text-main/src/components/Menu/MenuBar.vue
       <MainContainer> at /home/luka/nextcloud/text-main/src/components/Editor/MainContainer.vue
         <Wrapper> at /home/luka/nextcloud/text-main/src/components/Editor/Wrapper.vue
           <MarkdownContentEditor> at /home/luka/nextcloud/text-main/src/components/Editor/MarkdownContentEditor.vue
             <Root>

[Vue warn]: Invalid default value for prop "pluginKey": Props with type Object/Array must use a factory function to return the default value.

found in

---> <DragHandleVue>
       <ContentContainer> at /home/luka/nextcloud/text-main/src/components/Editor/ContentContainer.vue
         <MainContainer> at /home/luka/nextcloud/text-main/src/components/Editor/MainContainer.vue
           <Wrapper> at /home/luka/nextcloud/text-main/src/components/Editor/Wrapper.vue
             <MarkdownContentEditor> at /home/luka/nextcloud/text-main/src/components/Editor/MarkdownContentEditor.vue
               <Root>

@max-nextcloud
Copy link
Collaborator Author

Superseeded by #7643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants