-
Notifications
You must be signed in to change notification settings - Fork 109
fix(PreviewOptions): Move three-dot menu into preview box or link bubble #7793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
40c7623 to
68efd3a
Compare
68efd3a to
1163b5f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7793 +/- ##
==========================================
+ Coverage 53.34% 59.90% +6.55%
==========================================
Files 503 500 -3
Lines 43534 38345 -5189
Branches 1135 1091 -44
==========================================
- Hits 23225 22971 -254
+ Misses 20202 15269 -4933
+ Partials 107 105 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Fixes: #6814 (broken alignment of preview options in lists) * Fixes: #7693 (preview options displayed in read-only documents) * Fixes: nextcloud/collectives#1920 (hidden preview options on narrow screens) Also fixes the bug that the link is displayed above the preview in read-only view in Collectives. Signed-off-by: Jonas <[email protected]>
Great catch! Updated now and I also added a |
1163b5f to
d142d24
Compare
|
/backport to stable32 |
Fixes several UX bugs that stem from the existence of the three-dot menu for link preview options. It also will allow us to move drag handle and smart picker link closer to the editor container.
Contributes to #7272
Also fixes the bug that the link is displayed above the preview in read-only view in Collectives.
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)