Skip to content

[stable32] fix(PreviewOptions): Move three-dot menu into preview box or link bubble #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mejo- merged 2 commits into from
Oct 23, 2025
Merged

[stable32] fix(PreviewOptions): Move three-dot menu into preview box or link bubble #7813

mejo- merged 2 commits into from
Oct 23, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 21, 2025

Backport of PR #7793

@backportbot backportbot bot added this to the Nextcloud 32.0.1 milestone Oct 21, 2025
@mejo- @backportbot
fix(PreviewOptions): Move three-dot menu into preview box or link bubble
8d21c96 
* Fixes: #6814 (broken alignment of preview options in lists)
* Fixes: #7693 (preview options displayed in read-only documents)
* Fixes: nextcloud/collectives#1920 (hidden preview options on narrow screens)

Also fixes the bug that the link is displayed above the preview in
read-only view in Collectives.

Signed-off-by: Jonas <[email protected]>
@nextcloud-bot nextcloud-bot mentioned this pull request Oct 21, 2025
Merged
11 tasks
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 36.73469% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.95%. Comparing base (e2260ff) to head (14b679e).
⚠️ Report is 10 commits behind head on stable32.

Files with missing lines Patch % Lines
src/nodes/Preview.vue 17.39% 19 Missing ⚠️
src/components/Editor/PreviewOptions.vue 52.63% 9 Missing ⚠️
src/components/Link/LinkBubbleView.vue 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           stable32    #7813      +/-   ##
============================================
+ Coverage     53.39%   59.95%   +6.56%     
============================================
  Files           502      499       -3     
  Lines         43552    38365    -5187     
  Branches       1134     1090      -44     
============================================
- Hits          23254    23002     -252     
+ Misses        20191    15258    -4933     
+ Partials        107      105       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Oct 21, 2025
Merged
Closed
@mejo- mejo- merged commit 9a7d76c into stable32 Oct 23, 2025
63 of 66 checks passed
@mejo- mejo- deleted the backport/7793/stable32 branch October 23, 2025 21:03
@blizzz blizzz mentioned this pull request Nov 10, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- mejo- approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@benjaminfrueh benjaminfrueh benjaminfrueh approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels

3. to review bug Something isn't working feature: links ux

Projects

None yet

Milestone

Nextcloud 32.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@mejo- @marcoambrosini @benjaminfrueh