Import API and UI #106
Merged
Import API and UI #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
force-pushed
the
enh/import-from-ui
branch
from
81c6d8e to
e8b2f56
Compare
2 tasks
come-nc
reviewed
Apr 14, 2022
come-nc
reviewed
Apr 14, 2022
PVince81
reviewed
Apr 14, 2022
PVince81
reviewed
Apr 14, 2022
come-nc
reviewed
Apr 14, 2022
Collaborator
|
/rebase |
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
come-nc
force-pushed
the
enh/import-from-ui
branch
5 times, most recently
from
50bf960 to
9a02ca5
Compare
come-nc
force-pushed
the
enh/import-from-ui
branch
from
9a02ca5 to
50ecebf
Compare
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
enh/import-from-ui
branch
from
50ecebf to
fefe255
Compare
Signed-off-by: Côme Chilliet <[email protected]>
The source user is not on our instance, this field actually store the author of the import, which has the file to import in its folder and will receive the notifications. We may want to add author to export jobs as well later. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
enh/import-from-ui
branch
from
44d6841 to
2cd744c
Compare
Signed-off-by: Côme Chilliet <[email protected]>
PVince81
reviewed
Apr 14, 2022
| throw new Error(`Invalid path: ${filePath}`) | ||
| } | ||
| // TODO remove the file extension check when the custom mime type filter is added | ||
| if (!filePath.endsWith('.nextcloud_export')) { |
Member
There was a problem hiding this comment.
I'll remove this in my other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the chain of PRs to be merged first in this order:
This one should be able to be merged at the end