Skip to content

Complete User migration settings UI #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 24 commits into from
Apr 13, 2022
Merged

Complete User migration settings UI #97

PVince81 merged 24 commits into from
Apr 13, 2022

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Apr 13, 2022 •
edited
Loading

This completes the UI part, connecting the import functionality to the backend will require:

Screenshots in #75

@Pytal Pytal added 3. to review Waiting for reviews enhancement New feature request labels Apr 13, 2022
@Pytal Pytal requested review from PVince81 and come-nc April 13, 2022 02:18
@Pytal Pytal self-assigned this Apr 13, 2022
Pytal added 24 commits April 13, 2022 02:19
@Pytal
Note that data may be overwritten on import
965efff 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Add logger
7c1efe2 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Remove unused page controller
dc979ff 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Fix translations
aa296c8 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Remove unused constant
9e1a7d5 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Fix translations
35ce7b6 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Remove unused constant
60b1c1e 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Start with empty selected migrators array
a15204e 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Increase priority
ff422f6 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Remove deleted files from FilesMigrator description
b7e2206 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Add refresh status event
bb13729 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Update grid item size and spacing
b271765 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Show error dialog on failure to fetch migrators or status
9ccd2ec 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Show error dialog on export failure
433f4c5 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Show error dialog on import file picker failure
9404483 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Add spinner and update export modal state handling and styles
d0e9a9d 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Update wording
782432a 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Add readable status to API response
1b1079b 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Handle export status changes
fb39041 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Cleanup export section
22a3ba3 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Handle import status changes
42b1723 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Use min and max for grid columns
71a97b0 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Resolve style warnings
d48600d 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
Build js
4d76488 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal mentioned this pull request Apr 13, 2022
Closed
@Pytal Pytal added this to the 0.1 milestone Apr 13, 2022
PVince81
PVince81 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine

but one checkbox about the controller not ticked, maybe do separately?

@PVince81 PVince81 merged commit 6391e9f into main Apr 13, 2022
@PVince81 PVince81 deleted the enh/ui branch April 13, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews enhancement New feature request

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal @PVince81