Skip to content

Conversation

@pulsejet
Copy link
Member

I think this needs to take priority before NC 25 is released with broken HEIC support.

@skjnldsv @szaimen

@szaimen szaimen added the 3. to review Waiting for reviews label Oct 10, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Oct 10, 2022
@szaimen szaimen requested a review from artonge October 10, 2022 20:32
@pulsejet pulsejet force-pushed the patch-heic branch 2 times, most recently from 0b0c24b to 48fb2df Compare October 10, 2022 22:28
@skjnldsv
Copy link
Member

/rebase

@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 12, 2022
@skjnldsv skjnldsv added bug Something isn't working regression Regression of a previous working feature medium Medium priority and removed backport-request Pending backport by the backport-bot labels Oct 12, 2022
@skjnldsv
Copy link
Member

Btw there will also be this to fix

const mimes = [
'image/bmp',
'image/heic',
'image/heif',
'image/jpeg',
'image/png',
'image/tiff',
'image/webp',
'image/x-xbitmap',
]

I can tackle that a bit later :)

@skjnldsv
Copy link
Member

Seems the compile bot didn't want to work.
let me tackle that now then

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2022
@skjnldsv skjnldsv merged commit 703227a into nextcloud:master Oct 13, 2022
@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 13, 2022
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Oct 13, 2022
@skjnldsv
Copy link
Member

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 13, 2022
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request Pending backport by the backport-bot bug Something isn't working medium Medium priority regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants