Skip to content

[stable25] Fix regression: Use preview for unsupported images (fix #1408) #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Oct 13, 2022
Merged

[stable25] Fix regression: Use preview for unsupported images (fix #1408) #1411

skjnldsv merged 1 commit into from
Oct 13, 2022

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 13, 2022 •
edited by skjnldsv
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #1409

@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working medium Medium priority regression Regression of a previous working feature labels Oct 13, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25 milestone Oct 13, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Oct 13, 2022

/compile amend /

@pulsejet @nextcloud-command
Use preview for unsupported images (fix #1408)
6137a0a 
Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv
Copy link
Member

skjnldsv commented Oct 13, 2022

@PVince81 this is a regression and needs to get in for 25 (and 24 via support)

@blizzz blizzz mentioned this pull request Oct 13, 2022
Merged
2 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Oct 13, 2022

Cypress failure is pixel-change on visual regression. We can merge

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Oct 13, 2022
@skjnldsv skjnldsv requested review from a team, Pytal and szaimen and removed request for a team October 13, 2022 12:49
szaimen
szaimen approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv merged commit 399c4e7 into stable25 Oct 13, 2022
@skjnldsv skjnldsv deleted the backport/1409/stable25 branch October 13, 2022 16:24
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pulsejet pulsejet pulsejet approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working medium Medium priority regression Regression of a previous working feature

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @pulsejet @szaimen