Code review - single button to toggle full screen

Co-authored-by: John Molakvoæ <[email protected]>
Signed-off-by: Dariusz Olszewski <[email protected]>

src/views/Viewer.vue

@@ -78,21 +78,14 @@
 				{{ t('viewer', 'Edit') }}
 			</NcActionButton>
 			<!-- Menu items -->
-			<NcActionButton v-if="!isFullscreenMode"
+			<NcActionButton
 				:close-after-click="true"
-				@click="requestFullscreen">
+				@click="toggleFullScreen">
 				<template #icon>
-					<Fullscreen :size="20" />
+					<Fullscreen v-if="!isFullscreenMode" :size="20" />
+					<FullscreenExit v-else :size="20" />
 				</template>
-				{{ t('viewer', 'Full screen') }}
-			</NcActionButton>
-			<NcActionButton v-else
-				:close-after-click="true"
-				@click="exitFullscreen">
-				<template #icon>
-					<FullscreenExit :size="20" />
-				</template>
-				{{ t('viewer', 'Exit full screen') }}
+				{{ isFullscreenMode ? t('viewer', 'Exit full screen') : t('viewer', 'Full screen') }}
 			</NcActionButton>
 			<NcActionButton v-if="Sidebar && sidebarOpenFilePath && !isSidebarShown"
 				:close-after-click="true"
@@ -1019,6 +1012,14 @@ export default {
 		// Implementation based on:
 		//   https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API/Guide
 
+		toggleFullScreen() {
+			if (this.isFullscreenMode) {
+				this.exitFullscreen()
+			} else {
+				this.requestFullscreen()
+			}
+		},
+
 		requestFullscreen() {
 			const el = document.documentElement
 			if (el.requestFullscreen) {