Skip to content

Full screen mode #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 16 commits into from
May 3, 2023
Merged

Full screen mode #1588

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c57e1b7
Full screen mode - initial implementation
starypatyk Mar 26, 2023
c5e14e2
lint
starypatyk Mar 26, 2023
cddde00
Experiment - 100% height for content
starypatyk Mar 26, 2023
73d3cba
Minor corrections/simplification
starypatyk Mar 27, 2023
f09a4cd
Code review - BEM syntax
starypatyk Mar 28, 2023
3a2f496
Code review - single button to toggle full screen
starypatyk Mar 29, 2023
3934a4a
Use entire screen height only for images
starypatyk Apr 16, 2023
0b2e652
Simplify header bar for images in full screen
starypatyk Apr 17, 2023
25b0a28
Full screen mode - lint again
starypatyk Apr 19, 2023
2fa6887
Fix failing test - download-share.cy.js
starypatyk Apr 19, 2023
ab692ca
Additional fixes for failing cypress tests
starypatyk Apr 19, 2023
55eb30a
Update base image for failing cypress test
starypatyk Apr 27, 2023
59e2223
Update base image for failing cypress test (again)
starypatyk Apr 27, 2023
a50631a
Full screen mode - compile after rebase
starypatyk Apr 27, 2023
cddba04
Cypress - update another base image (focus ring)
starypatyk Apr 28, 2023
1d6a18e
Code review - simplify special handling of images
starypatyk Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code review - BEM syntax 
Signed-off-by: Dariusz Olszewski <[email protected]>
  • Loading branch information
@starypatyk
starypatyk committed Apr 27, 2023
commit f09a4cdafac30de0183314b2311e9ba9bdf2db27
6 changes: 3 additions & 3 deletions src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,9 @@ export default {
isFullscreenMode(mode) {
const modalContainer = document.getElementsByClassName('modal-container').item(0)
if (mode) {
modalContainer.classList.add('modal-container-fullscreen')
modalContainer.classList.add('modal-container--fullscreen')
} else {
modalContainer.classList.remove('modal-container-fullscreen')
modalContainer.classList.remove('modal-container--fullscreen')
}
},

Expand Down Expand Up @@ -1085,7 +1085,7 @@ export default {
background-color: transparent;
box-shadow: none;
}
.modal-container-fullscreen {
.modal-container--fullscreen {
top: 0;
bottom: 0;
height: 100%;
Expand Down