fix: image editor focus trap #2893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
bug
hamza221
force-pushed
the
Fix/image-editor-focus
branch
from
1de559e to
21ff736
Compare
Contributor
Author
|
/compile |
hamza221
force-pushed
the
Fix/image-editor-focus
branch
from
21ff736 to
e3d12c3
Compare
Contributor
Author
|
/compile |
skjnldsv
approved these changes
Jul 1, 2025
hamza221
force-pushed
the
Fix/image-editor-focus
branch
from
9d6bdbe to
c17fdcc
Compare
Signed-off-by: Hamza <[email protected]>
hamza221
force-pushed
the
Fix/image-editor-focus
branch
from
c17fdcc to
aa5d9b5
Compare
Contributor
Author
|
/compile |
Contributor
Author
|
/backport aa5d9b5 to stable30 please |
Contributor
Author
|
/backport aa5d9b5 to stable31 please |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2891
Mutations events are deprecated - > https://chromestatus.com/feature/5083947249172480
This also fixes focus in the save modal, without this patch file name can't be edited
PS: I was not able to fix tab navigation on main Image editor modal