Skip to content

ImageEditor.vue:136 [Deprecation] Listener added for a 'DOMNodeInserted' mutation event. Support for this event type has been removed, and this event will no longer be fired. #2891

@kesselb

Description

@kesselb

Describe the bug

ImageEditor.vue:136 [Deprecation] Listener added for a 'DOMNodeInserted' mutation event. Support for this event type has been removed, and this event will no longer be fired.

As suggested, we might consider replacing the listener with a MutationObserver.

From what I understand in the pull request at #1319, the reason for this event listener was related to menus not functioning properly. The event is still available in Firefox but has been removed in Chrome. In my tests, both browsers seem to behave the same and I can use Nextcloud's sidebar, the image editor's "save as" feature and submenus.

It's possible that the event listener is no longer necessary. I would be happy to send a pull request, but I'm not entirely sure about the original reason for the event listener.

To Reproduce

  1. Open the browser's console
  2. Open the image editor
  3. See the deprecation warning

Expected behavior

No warning

Screenshots

Image

Additional context

This was reported by @trajano at https://help.nextcloud.com/t/so-long-nextcloud/226782/10?u=kesselb (warning: rant post the forum thread do not provide any additional data)

Metadata

Metadata

Assignees

No one assigned

    Labels

    0. Needs triagePending approval or rejection. This issue is pending approval.bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions