Skip to content

fix(Viewer): Provide id instead of fileid to File constructor #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Oct 14, 2025
Merged

fix(Viewer): Provide id instead of fileid to File constructor #2988

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
417df0b
fix(Viewer): Provide `id` instead of `fileid` to `File` constructor
artonge Oct 9, 2025
a487e3b
chore(assets): Recompile assets
nextcloud-command Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(Viewer): Provide id instead of fileid to File constructor 
The `Node` object uses the `id` property in the `fileid` getter: https://github.com/nextcloud-libraries/nextcloud-files/blob/62c497479945f84249366690310ff1180198f85b/lib/node/node.ts#L331-L332

Signed-off-by: Louis Chmn <[email protected]>
  • Loading branch information
@artonge
artonge committed Oct 9, 2025
commit 417df0b88775e05f3af4cdae309355ce0291809a
4 changes: 2 additions & 2 deletions src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ export default defineComponent({
const nodes = filteredFiles.map(
file => new NcFile({
source: davRemoteURL + davGetRootPath() + file.filename,
fileid: file.fileid,
id: file.fileid,
displayname: file.displayname,
mime: file.mime,
mtime: new Date(file.lastmod),
Expand Down Expand Up @@ -1166,7 +1166,7 @@ export default defineComponent({
// Fake node to emit the event until Viewer is migrated to the new Node API.
const node = new NcFile({
source: url,
fileid,
id: fileid,
mime: this.currentFile.mime,
owner: this.currentFile.ownerId,
root: url.includes('remote.php/dav') ? davGetRootPath() : undefined,
Expand Down
Loading