Skip to content

Conversation

@tabedzki
Copy link
Contributor

While the fix merged in #2991 addressed a share, it inadvertently broke navigating through images for regular file viewing (non-shares). This fix uses the join, dirPath and node.basename to reconstruct the paths that works for both shares and non-shared views.

I've tested this lean version of the nextcloud-docker-dev repo as of 2025-Oct-27 for (1) regular file navigation, (2) the root of a share for images and (3) within subfolders for the share. The check for length 0 is needed for images in the root of a share. Originally, the dirPath evaluated to / but now it evaluates to an empty string.

Sorry @skjnldsv about the headache that this has caused.

While the fix merged in nextcloud#2991 addressed a share, it inadvertently broke navigating through images for regular file viewing. This fix uses the `join`, `dirPath` and `node.basename` to reconstruct the paths that works for both shares and non-shared views.

Signed-off-by: tabedzki <[email protected]>
@skjnldsv
Copy link
Member

Hey @tabedzki no worries, something else was the issue.
Please have a look at #3005

@skjnldsv skjnldsv closed this Oct 28, 2025
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants