Skip to content

fix(viewer): used join to fix issues stemming from #2991 #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tabedzki wants to merge 2 commits into from
Closed

fix(viewer): used join to fix issues stemming from #2991 #3004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc8932
fix(viewer): used join to fix issues stemming from #2991
tabedzki Oct 27, 2025
3630aed
fix(viewer): Replaced empty dirPath String with with a root `/`
tabedzki Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@
import '@nextcloud/dialogs/style.css'
import Vue, { defineComponent } from 'vue'

import { join } from 'path'


import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus'
import { loadState } from '@nextcloud/initial-state'
import { File as NcFile, Node, davRemoteURL, davRootPath, davGetRootPath, sortNodes } from '@nextcloud/files'
Expand Down Expand Up @@ -795,8 +798,12 @@ export default defineComponent({
sortingOrder: this.sortingConfig.asc ? 'asc' : 'desc',
})

let tmp_path
tmp_path = dirPath
if (tmp_path.length === 0 ) {tmp_path = "/"}

this.fileList = sortedNodes.map(node => {
return filteredFiles.find(file => file.filename === String(dirPath + node.path))
return filteredFiles.find(file => file.filename === join(tmp_path, node.basename))
})
// store current position
this.currentIndex = this.fileList.findIndex(file => file.filename === fileInfo.filename)
Expand Down