Italian Alexa Update #4038
Italian Alexa Update #4038
Conversation
Italian Alexa update
Alexa metric synonyms
|
Added other translations. @PieterGit tested and full working in Italian also for metrics. |
|
@francesc0-cgm We need to see why this PR failed on Node 10 (and works on Node 8). Just restarted the build. Hoping @sulkaharo can have a look at it too. @francesc0-cgm I also would like a different Alexa user to confirm these changes work and don't cause problems for non-Italian Alexa users. Do you know of another Italian and non Italian user that can test? |
|
@francesc0-cgm Please also have a look at the Codacy error: |
|
Ok, restarting the Node 10 build fixed the problem, so it's some kind of Travis weirdness. If the Codacy error is resolved and if we can find a confirmation that it works or does not regresses stuff for non italian users, I will merge the pull request. |
|
I confirm that worked for another italian girl, except for loop prediction that is still in english. For other languages we should wait someone else |
/improved error message for missing loop data
Alexa metric synonyms
|
Translated new loop working forecast. |
|
Hi @francesc0-cgm I could help you testing this PR. |
|
Here it is
https://api.myjson.com/bins/1dgady
Inviato da iPhone
… Il giorno 14 nov 2018, alle ore 15:31, MoNsTeR ***@***.***> ha scritto:
Hi @francesc0-cgm I could help you testing this PR.
Where can I find the .json for the italian skill?
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@francesc0-cgm I moved the I discussed with @sulkaharo and the Alexa plugin should be more loosely coupled from the other files. I hope @sulkaharo can review this and that @francesc0-cgm and perhaps other Alexa users/developers can fix this for the Nightscout 0.11 update. |
|
I think docs is clear and easy to apply @PieterGit |
| }; | ||
|
|
||
| function alexaAr2Handler (next, slots, sbx) { | ||
| function alexaAr2Handler(next, slots, sbx) { |
There was a problem hiding this comment.
The ar2.js should not contain any alexa specific code in it.
| function alexaCOBHandler (next, slots, sbx) { | ||
| var preamble = (slots && slots.pwd && slots.pwd.value) ? slots.pwd.value.replace('\'s', '') + ' has' : 'You have'; | ||
| var value = 'no'; | ||
| function alexaCOBHandler(next, slots, sbx) { |
There was a problem hiding this comment.
this should not be in the basic COB code, but be abstracted in the alexa plugin
|
@francesc0-cgm Please check #4980 and help test that Alexa integration. If this PR can be reimplemented in a generic way please rewrite the PR to do so. Closing this PR due to merge conflicts and out of date. |
|
@francesc0-cgm Your translation work would be very helpful! #4980 provides instructions on how to add additional language support in the way the virtual assistants are built to handle it. |
5 participants
All Alexa answers translation in Italian