Add a Modern PCL project that also support CoreClr #200
Conversation
…'t affect other projects when VS 2015 UWP 10 tools is installed.
There was a problem hiding this comment.
I would recommend using NuSpec.ReferenceGenerator to add/update the dependencies as they can change over time and the tool will ensure they're up-to-date.
There was a problem hiding this comment.
I actually tried. But for some reason it didn't work. NuSpec.ReferenceGenerator wasn't getting added to the project.json. I didn't have time to look into it yet.
|
Can you please add a unit test project for DNX as well? |
…Most of the changes are mimicing what WINRT project does. Add a dnx test project. It references the output of Ninject-dotnet project via a wrap project of "wrap\Ninject\project.json". 324 tests passed in VS, while 330 passed using "dnx test". However this moq based tests are disabled by NO_MOQ for now since the official Moq doesn't support CoreClr yet.
|
Thanks for asking to add the test project. It revealed that I cannot just simply copy the PCL project. |
|
Looks like the build machine doesn't support .Net 4.6. |
There was a problem hiding this comment.
I don't understand why adding a Modern PCL project creates so many configurations.
|
Working on the build machine. AppVeyor is setup but the current build server is interfering |
|
@onovotny is there anything I can do to move this PR forward? |
|
What's the status of this? I think the new infrastructure has now sufficiently stabilized to start building netstandard compatible packages. A starting point might be ah-@b6820cb, would you accept an updated PR? |
|
Closing as the master branch already has netstandard support. |
3 participants
For #185
This is mostly a copy of the old portable csproj, with different targeted profile.