Skip to content

Add a Modern PCL project that also support CoreClr #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Add a Modern PCL project that also support CoreClr #200

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3dce0d8
Add a modern PCL project that targets .Net 4.6, UWP 10, and Asp.Net 5.
jeremymeng Nov 24, 2015
5749dd8
Fix warnings.
jeremymeng Nov 24, 2015
c6ee924
Add dotnet group.
jeremymeng Nov 24, 2015
6bbe40b
Move Ninject-dotnet proejct into a separate folder so its project don…
jeremymeng Nov 24, 2015
531bb82
Use NuSpec.ReferenceGenerator to managed 'dotnet' dependency group.
jeremymeng Nov 25, 2015
3248d8e
Fix the dotnet project as it cannot be simply a copy of PCL project. …
jeremymeng Nov 25, 2015
c5a7bb8
Disable Moq tests as it doesn't officially support CoreClr.
jeremymeng Nov 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion Ninject.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 14
VisualStudioVersion = 14.0.22823.1
VisualStudioVersion = 14.0.23107.0
MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{3E299B94-5F07-49DE-8226-55EDC56F13E3}"
ProjectSection(SolutionItems) = preProject
Expand Down Expand Up @@ -55,6 +55,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ninject.Android.Tests", "sr
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ninject.iOS-Unified", "src\Ninject\Ninject.iOS-Unified.csproj", "{420ACA2A-7853-4C5D-A3B1-E7AE938A801F}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ninject-dotnet", "src\Ninject.dotnet\Ninject-dotnet.csproj", "{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -424,6 +426,30 @@ Global
{420ACA2A-7853-4C5D-A3B1-E7AE938A801F}.Release|Mixed Platforms.ActiveCfg = Release|Any CPU
{420ACA2A-7853-4C5D-A3B1-E7AE938A801F}.Release|Mixed Platforms.Build.0 = Release|Any CPU
{420ACA2A-7853-4C5D-A3B1-E7AE938A801F}.Release|x86.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
Copy link
Author

@jeremymeng jeremymeng Nov 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why adding a Modern PCL project creates so many configurations.

{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|Any CPU.Build.0 = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|ARM.ActiveCfg = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|ARM.Build.0 = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|iPhone.ActiveCfg = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|iPhone.Build.0 = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|iPhoneSimulator.ActiveCfg = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|iPhoneSimulator.Build.0 = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|Mixed Platforms.ActiveCfg = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|Mixed Platforms.Build.0 = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|x86.ActiveCfg = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Debug|x86.Build.0 = Debug|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|Any CPU.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|Any CPU.Build.0 = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|ARM.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|ARM.Build.0 = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|iPhone.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|iPhone.Build.0 = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|iPhoneSimulator.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|iPhoneSimulator.Build.0 = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|Mixed Platforms.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|Mixed Platforms.Build.0 = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|x86.ActiveCfg = Release|Any CPU
{00A3D52F-BA8F-49A3-BDF8-FA457E866F3A}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
20 changes: 20 additions & 0 deletions Portable.Ninject.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,22 @@
<summary>IoC container for .NET</summary>
<releaseNotes>Xamarin support for iOS and Android</releaseNotes>
<tags>Ninject ioc di portable pcl xamarin ios android monotouch monoandroid</tags>
<dependencies>
<group targetFramework="dotnet">
Copy link

@clairernovotny clairernovotny Nov 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using NuSpec.ReferenceGenerator to add/update the dependencies as they can change over time and the tool will ensure they're up-to-date.

Copy link
Author

@jeremymeng jeremymeng Nov 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually tried. But for some reason it didn't work. NuSpec.ReferenceGenerator wasn't getting added to the project.json. I didn't have time to look into it yet.

<dependency id="System.Collections" version="4.0.10" />
<dependency id="System.ComponentModel" version="4.0.0" />
<dependency id="System.Diagnostics.Debug" version="4.0.10" />
<dependency id="System.IO" version="4.0.10" />
<dependency id="System.Linq" version="4.0.0" />
<dependency id="System.Linq.Expressions" version="4.0.10" />
<dependency id="System.Reflection" version="4.0.10" />
<dependency id="System.Reflection.Extensions" version="4.0.0" />
<dependency id="System.Runtime" version="4.0.20" />
<dependency id="System.Runtime.Extensions" version="4.0.10" />
<dependency id="System.Threading" version="4.0.10" />
<dependency id="System.Threading.Timer" version="4.0.0" />
</group>
</dependencies>
</metadata>
<files>

Expand Down Expand Up @@ -59,6 +75,10 @@
<file src="src\Ninject\bin\Android\Release\Ninject.pdb" target="lib\monoandroid\Ninject.pdb" />
<file src="src\Ninject\bin\Android\Release\Ninject.xml" target="lib\monoandroid\Ninject.xml" />

<!-- dotnet -->
<file src="src\Ninject\bin\dotnet\Release\Ninject.dll" target="lib\dotnet\Ninject.dll" />
<file src="src\Ninject\bin\dotnet\Release\Ninject.pdb" target="lib\dotnet\Ninject.pdb" />
<file src="src\Ninject\bin\dotnet\Release\Ninject.xml" target="lib\dotnet\Ninject.xml" />

<file src="src\**\*.cs" target="src" exclude="src\_ReSharper.*\**\*.*;packages\**\*.*;src\**\Debug\**\*.*;" />
</files>
Expand Down
Loading